sdk: Rename ed25519-instructions -> ed25519-program#3632
Merged
joncinque merged 2 commits intoanza-xyz:masterfrom Nov 14, 2024
Merged
sdk: Rename ed25519-instructions -> ed25519-program#3632joncinque merged 2 commits intoanza-xyz:masterfrom
joncinque merged 2 commits intoanza-xyz:masterfrom
Conversation
#### Problem The precompiles behave more like programs than instructions, as was decided with the new secp256r1 precompile in solana-labs#3152, but the ed25519 precompile was split as `ed25519-instructions`. #### Summary of changes Rename the crate from `solana-ed25519-instructions` to `solana-ed25519-program`, which is a previous crate that used to be used until solana-labs#19930.
kevinheavey
approved these changes
Nov 14, 2024
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Nov 14, 2024
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Nov 14, 2024
febo
approved these changes
Nov 14, 2024
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Nov 14, 2024
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Nov 14, 2024
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Nov 15, 2024
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Nov 16, 2024
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Nov 20, 2024
kevinheavey
added a commit
to kevinheavey/agave
that referenced
this pull request
Nov 20, 2024
febo
pushed a commit
that referenced
this pull request
Nov 20, 2024
* start extracting secp256k1-instruction * fix imports and dependencies * fix docs * activate solana-secp256k1-instruction/bincode in solana-sdk * import program id from solana_sdk_ids * rename to solana-secp256k1-program like in #3632 * update lock file after rebase * tighten deps * minimise solana-sdk usage in docs and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The precompiles behave more like programs than instructions, as was decided with the new secp256r1 precompile in #3152, but the ed25519 precompile was split as
ed25519-instructionsin #3330.Summary of changes
Rename the crate from
solana-ed25519-instructionstosolana-ed25519-program, which is a previous crate that used to be used until solana-labs#19930.